hotfix: merge <<< HEAD ---- >>> SHA1 messages stood on the code somehow

Reviewed-on: #3

backlib/pom.xml

@@ -4,7 +4,7 @@
 	<modelVersion>4.0.0</modelVersion>
 	<groupId>net.miarma.api</groupId>
 	<artifactId>backlib</artifactId>
-	<version>1.2.0</version>
+	<version>1.2.1</version>
 
 	<properties>
 		<maven.compiler.source>23</maven.compiler.source>

backlib/src/main/java/net/miarma/api/backlib/middlewares/AbstractAuthGuard.java

@@ -14,12 +14,12 @@ import net.miarma.api.backlib.util.JsonUtil;
  * Maneja extracción de JWT y verificación básica.
  * Los microservicios solo implementan getUserEntity y hasPermission.
  */
-@SuppressWarnings("unchecked")  // arreglar el warning de heap pollution de los arrays de genéricos
+@SuppressWarnings("unchecked")
 public abstract class AbstractAuthGuard<U, R extends Enum<R> & IUserRole> {
     
     protected abstract R parseRole(String roleStr);
     protected abstract void getUserEntity(int userId, RoutingContext ctx, Consumer<U> callback);
-    protected abstract boolean hasPermission(U user, R role, R... allowedRoles);
+    protected abstract boolean hasPermission(U user, R role);
 
     public Handler<RoutingContext> check(R... allowedRoles) {
         return ctx -> {
@@ -30,6 +30,18 @@ public abstract class AbstractAuthGuard<U, R extends Enum<R> & IUserRole> {
             }
 
             int userId = JWTManager.getInstance().extractUserId(token);
+            String roleStr = JWTManager.getInstance().extractRole(token);
+            
+            R role;
+            try {
+                role = parseRole(roleStr);
+             } catch (Exception e) {
+                JsonUtil.sendJson(ctx, ApiStatus.UNAUTHORIZED, "Invalid role");
+                return;
+             }
+            
+            ctx.put("userId", userId);
+            ctx.put("role", role);
             
             getUserEntity(userId, ctx, entity -> {
                 if (entity == null) {
@@ -37,9 +49,7 @@ public abstract class AbstractAuthGuard<U, R extends Enum<R> & IUserRole> {
                     return;
                 }
 
-                R userRole = extractRoleFromEntity(entity);
+                if (allowedRoles.length == 0 || isRoleAllowed(role, allowedRoles)) {
-
-                if (allowedRoles.length == 0 || hasPermission(entity, userRole, allowedRoles)) {
                     ctx.put("userEntity", entity);
                     ctx.next();
                 } else {
@@ -49,15 +59,11 @@ public abstract class AbstractAuthGuard<U, R extends Enum<R> & IUserRole> {
         };
     }
     
-    protected R extractRoleFromEntity(U user) {
+    protected boolean isRoleAllowed(R role, R... allowedRoles) {
-        try {
+        for (R allowed : allowedRoles) if (role == allowed) return true; return false;
-            return (R) user.getClass().getMethod("getRole").invoke(user);
-        } catch (Exception e) {
-            return null;
-        }
     }
 
-    private String extractToken(RoutingContext ctx) {
+    protected String extractToken(RoutingContext ctx) {
         String authHeader = ctx.request().getHeader("Authorization");
         if (authHeader != null && authHeader.startsWith("Bearer ")) {
             return authHeader.substring(7);

bootstrap/pom.xml

@@ -5,8 +5,8 @@
 
     <parent>
         <groupId>net.miarma.api</groupId>
-        <artifactId>miarma-backend</artifactId>
+        <artifactId>miarma-ecosystem</artifactId>
-        <version>1.2.0</version>
+        <version>1.2.1</version>
     </parent>
 
     <artifactId>bootstrap</artifactId>

microservices/core/pom.xml

@@ -2,7 +2,7 @@
   <modelVersion>4.0.0</modelVersion>
   <groupId>net.miarma.api</groupId>
   <artifactId>core</artifactId>
-  <version>1.2.0</version>
+  <version>1.2.1</version>
   
   <properties>
     <maven.compiler.source>23</maven.compiler.source>
@@ -20,9 +20,8 @@
 	<dependency>
         <groupId>net.miarma.api</groupId>
         <artifactId>backlib</artifactId>
-        <version>1.2.0</version>
+        <version>1.2.1</version>
-        <scope>provided</scope>
   </dependency>
   </dependencies>
-  
 </project>
+

microservices/core/src/main/java/net/miarma/api/microservices/core/routing/middlewares/CoreAuthGuard.java

@@ -29,10 +29,8 @@ public class CoreAuthGuard extends AbstractAuthGuard<UserEntity, CoreUserRole> {
     }
 
     @Override
-    protected boolean hasPermission(UserEntity member, CoreUserRole userRole, CoreUserRole... allowedRoles) {
+    protected boolean hasPermission(UserEntity user, CoreUserRole userRole) {
-        if (member == null) return false;
+        return user.getGlobal_role() == CoreUserRole.ADMIN;
-        if (member.getGlobal_role() == CoreUserRole.ADMIN) return true;
-        return false;
     }
 
 }

microservices/huertos/pom.xml

@@ -2,7 +2,7 @@
   <modelVersion>4.0.0</modelVersion>
   <groupId>net.miarma.api</groupId>
   <artifactId>huertos</artifactId>
-  <version>1.2.0</version>
+  <version>1.2.1</version>
   
   <properties>
     <maven.compiler.source>23</maven.compiler.source>
@@ -20,8 +20,7 @@
 	<dependency>
         <groupId>net.miarma.api</groupId>
         <artifactId>backlib</artifactId>
-        <version>1.2.0</version>
+        <version>1.2.1</version>
-        <scope>provided</scope>
   </dependency>
   </dependencies>
   

microservices/huertos/src/main/java/net/miarma/api/microservices/huertos/routing/middlewares/HuertosAuthGuard.java

@@ -2,13 +2,18 @@ package net.miarma.api.microservices.huertos.routing.middlewares;
 
 import java.util.function.Consumer;
 
+import io.vertx.core.Handler;
 import io.vertx.ext.web.RoutingContext;
 import net.miarma.api.backlib.Constants.HuertosUserRole;
+import net.miarma.api.backlib.http.ApiStatus;
 import net.miarma.api.backlib.middlewares.AbstractAuthGuard;
+import net.miarma.api.backlib.security.JWTManager;
+import net.miarma.api.backlib.util.JsonUtil;
 import net.miarma.api.microservices.huertos.entities.MemberEntity;
 import net.miarma.api.microservices.huertos.services.MemberService;
 
 public class HuertosAuthGuard extends AbstractAuthGuard<MemberEntity, HuertosUserRole> {
+
     private final MemberService memberService;
 
     public HuertosAuthGuard(MemberService memberService) {
@@ -29,13 +34,43 @@ public class HuertosAuthGuard extends AbstractAuthGuard<MemberEntity, HuertosUse
     }
 
     @Override
-    protected boolean hasPermission(MemberEntity member, HuertosUserRole userRole, HuertosUserRole... allowedRoles) {
+    protected boolean hasPermission(MemberEntity member, HuertosUserRole userRole) {
-        if (member == null) return false;
+    	return member.getRole() == HuertosUserRole.ADMIN;
-        if (member.getRole() == HuertosUserRole.ADMIN || member.getRole() == HuertosUserRole.DEV) return true;
-        for (HuertosUserRole role : allowedRoles) {
-            if (member.getRole() == role) return true;
     }
-        return false;
+
+    @Override
+    public Handler<RoutingContext> check(HuertosUserRole... allowedRoles) {
+        return ctx -> {
+            String token = extractToken(ctx);
+            if (token == null || !JWTManager.getInstance().isValid(token)) {
+                JsonUtil.sendJson(ctx, ApiStatus.UNAUTHORIZED, "Invalid or missing token");
+                return;
+            }
+
+            int userId = JWTManager.getInstance().extractUserId(token);
+
+            getUserEntity(userId, ctx, member -> {
+                if (member == null) {
+                    JsonUtil.sendJson(ctx, ApiStatus.UNAUTHORIZED, "User not found");
+                    return;
+                }
+
+                HuertosUserRole role = HuertosUserRole.USER;
+                if (member.getRole() != null) {
+                    role = member.getRole();
+                }
+
+                ctx.put("userId", userId);
+                ctx.put("role", role);
+                ctx.put("userEntity", member);
+
+                if (allowedRoles.length == 0 || isRoleAllowed(role, allowedRoles)) {
+                    ctx.next();
+                } else {
+                    JsonUtil.sendJson(ctx, ApiStatus.FORBIDDEN, "Forbidden");
+                }
+            });
+        };
     }
 
 }

microservices/huertosdecine/pom.xml

@@ -2,7 +2,7 @@
   <modelVersion>4.0.0</modelVersion>
   <groupId>net.miarma.api</groupId>
   <artifactId>huertosdecine</artifactId>
-  <version>1.2.0</version>
+  <version>1.2.1</version>
   
   <properties>
     <maven.compiler.source>23</maven.compiler.source>
@@ -20,8 +20,7 @@
 	<dependency>
         <groupId>net.miarma.api</groupId>
         <artifactId>backlib</artifactId>
-        <version>1.2.0</version>
+        <version>1.2.1</version>
-        <scope>provided</scope>
     </dependency>
   </dependencies>
   

microservices/huertosdecine/src/main/java/net/miarma/api/microservices/huertosdecine/routing/middlewares/CineAuthGuard.java

@@ -29,13 +29,8 @@ public class CineAuthGuard extends AbstractAuthGuard<ViewerEntity, CineUserRole>
     }
 
     @Override
-    protected boolean hasPermission(ViewerEntity member, CineUserRole userRole, CineUserRole... allowedRoles) {
+    protected boolean hasPermission(ViewerEntity user, CineUserRole userRole) {
-        if (member == null) return false;
+    	return user.getRole() == CineUserRole.ADMIN;
-        if (member.getRole() == CineUserRole.ADMIN) return true;
-        for (CineUserRole role : allowedRoles) {
-            if (member.getRole() == role) return true;
-        }
-        return false;
     }
 
 }

microservices/miarmacraft/pom.xml

@@ -2,7 +2,7 @@
   <modelVersion>4.0.0</modelVersion>
   <groupId>net.miarma.api</groupId>
   <artifactId>miarmacraft</artifactId>
-  <version>1.2.0</version>
+  <version>1.2.1</version>
   
   <properties>
     <maven.compiler.source>23</maven.compiler.source>
@@ -20,8 +20,7 @@
 	<dependency>
         <groupId>net.miarma.api</groupId>
         <artifactId>backlib</artifactId>
-        <version>1.2.0</version>
+        <version>1.2.1</version>
-        <scope>provided</scope>
     </dependency>
   </dependencies>
   

microservices/miarmacraft/src/main/java/net/miarma/api/microservices/miarmacraft/routing/middlewares/MMCAuthGuard.java

@@ -29,13 +29,8 @@ public class MMCAuthGuard extends AbstractAuthGuard<PlayerEntity, MMCUserRole> {
     }
 
     @Override
-    protected boolean hasPermission(PlayerEntity member, MMCUserRole userRole, MMCUserRole... allowedRoles) {
+    protected boolean hasPermission(PlayerEntity user, MMCUserRole userRole) {
-        if (member == null) return false;
+    	return user.getRole() == MMCUserRole.ADMIN;
-        if (member.getRole() == MMCUserRole.ADMIN) return true;
-        for (MMCUserRole role : allowedRoles) {
-            if (member.getRole() == role) return true;
-        }
-        return false;
     }
 
 }

microservices/mpaste/pom.xml

@@ -2,7 +2,7 @@
   <modelVersion>4.0.0</modelVersion>
   <groupId>net.miarma.api</groupId>
   <artifactId>mpaste</artifactId>
-  <version>1.2.0</version>
+  <version>1.2.1</version>
   
   <properties>
     <maven.compiler.source>23</maven.compiler.source>
@@ -20,8 +20,7 @@
 	<dependency>
         <groupId>net.miarma.api</groupId>
         <artifactId>backlib</artifactId>
-        <version>1.2.0</version>
+        <version>1.2.1</version>
-        <scope>provided</scope>
     </dependency>
   </dependencies>
   

pom.xml

@@ -4,8 +4,8 @@
 	<modelVersion>4.0.0</modelVersion>
 
 	<groupId>net.miarma.api</groupId>
-	<artifactId>miarma-backend</artifactId>
+	<artifactId>miarma-ecosystem</artifactId>
-	<version>1.2.0</version>
+	<version>1.2.1</version>
 	<packaging>pom</packaging>
 
 	<modules>